fix: enhance name splitting to handle "Lastname, Firstname" format - #62122
fix: enhance name splitting to handle "Lastname, Firstname" format#62122enjeck wants to merge 3 commits into
Conversation
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
ec835f7 to
5437266
Compare
|
How does it cover cases like this?
|
5437266 to
9a3b882
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
More or less that was implemented on Talk client side: https://github.com/nextcloud/spreed/pull/18682/changes Might be an overkill, but basics to match would be:
|
b28fbb6 to
5581ee3
Compare
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Maybe it also makes sense to reuse something like https://packagist.org/packages/iliaal/nameparser
And extend the languages not provided. It seems to contain many more entries for suffixes and salutations
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
5581ee3 to
89bc56a
Compare
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
I didn't realize we could add packages without some discussion about it before hand before hand about the supply chain risk. Also, it looks pretty new and shows only 400 installs so far. |
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
OK to follow Talk's approach for consistency. Switching for a dep can be considered later, then it would be good to have a one-way thing to do it across Nextcloud (and its apps).
4 participants
Summary
If an ActiveDirectory provides user names in the "Lastname, Firstname" format, Nextcloud attempts to split this string internally, but it maps the values the wrong way around.
This becomes very obvious in the Contacts app, where the "First name" field is incorrectly populated with the user's last name including the comma (e.g., "Lastname,"), and the "Last name" field contains the user's actual first name
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)